Build with CMake

[klimkin]

Some differences from original build - might need adjustments, please test on your platform:

• Uses default build flags for benchmarks. I did some testing using -DCMAKE_BUILD_TYPE=RelWithDebInfo, this way everything builds with "-g -O2".
• I see a recent commit adding -gdwarf-3. Please see if it's still needed. If so, will add to some of CMAKE_CXX_FLAGS_* variables.
• Benchmarks build only if providing -DBUILD_BENCHMARKS=ON cmake option.
• I am pulling build dependencies using Conan (see conanfile.txt). Appears to be most portable option.
• libelfin 0.2 doesn't work on SUSE. I am using the latest. CCI has the latest under 0.3 tag. See https://github.com/conan-io/conan-center-index/tree/master/recipes/libelfin

Full list of benchmark run targets:

• run_histogram_large
• run_histogram_small
• run_kmeans_small
• run_kmeans_large
• run_linear_regression_large
• run_linear_regression_small
• run_matrix_multiply_large
• run_matrix_multiply_small
• run_pbzip2_large
• run_pbzip2_small
• run_pca
• run_producer_consumer
• run_sqlite_bench_modified
• run_sqlite_bench
• run_string_match_large
• run_string_match_small
• run_toy
• run_word_count_large
• run_word_count_small

[emeryberger]

I see a recent commit adding -gdwarf-3. Please see if it's still needed. If so, will add to some of CMAKE_CXXFLAGS* variables.

I believe the answer to this question is "yes". Let me know when you think this is safe to merge.

[klimkin]

Both benchmarks and the library?

On Sat, Jan 9, 2021, 1:19 PM Emery Berger notifications@github.com wrote:

I see a recent commit adding -gdwarf-3. Please see if it's still needed. If so, will add to some of CMAKE_CXXFLAGS* variables.

I believe the answer to this question is "yes". Let me know when you think this is safe to merge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/plasma-umass/coz/pull/178#issuecomment-757368857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADD3XPSTKLIPB3JNRLBSIDSZDB53ANCNFSM4V2W27BA .

[emeryberger]

Probably both just to be on the safe side. See https://github.com/plasma-umass/coz/issues/107#issuecomment-708341054.

[Corristo]

I quickly glanced over the changes. As someone with a fair bit of experience with CMake I found a few things that could be changed to improve maintainability, developer experience and integration/consumption in other projects. If you're interested in that input I can compile a list or add comments in the diff view.

[klimkin]

Of course, please do!

On Sat, Jan 9, 2021, 3:03 PM Manuel Bergler notifications@github.com wrote:

I quickly glanced over the changes. As someone with a fair bit of experience with CMake I found a few things that could be changed to improve maintainability, developer experience and integration/consumption in other projects. If you're interested in that input I can compile a list or add comments in the diff view.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/plasma-umass/coz/pull/178#issuecomment-757380718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADD3XJ7IJSWP63QSVDUUADSZDOETANCNFSM4V2W27BA .

[emeryberger]

Hi @klimkin and @Corristo - let me know if there’s anything I can do on this front. Thanks!

[klimkin]

@Corristo It's ready for the next iteration of the review. Please see my comments above.

[klimkin]

Hi @klimkin and @Corristo - let me know if there’s anything I can do on this front. Thanks!

@emeryberger Could you see if it builds and works the same way on your system, please?

[klimkin]

Merge?