is the `rimraf` dependency required?

plasma-umass / doppio

Breaks the browser language barrier (includes a plugin-free JVM).

http://plasma-umass.github.io/doppio-demo

MIT License

2.16k stars 175 forks source link

is the `rimraf` dependency required? #410

Closed hrj closed 8 years ago

hrj commented 8 years ago

I couldn't find a use for it in any of the source folders.

jvilk commented 8 years ago

It may be a peerDependency, which need to be explicitly included for NPM 3. But I don't know off the top of my head. It may also be something I used before, and stopped using later.

jvilk commented 8 years ago

Turns out: No, it's not needed.

hrj commented 8 years ago

Turns out: it is needed during installation of JDK :)

console/download_jdk.ts requires it.

So you probably will have to revert https://github.com/plasma-umass/doppio/commit/e76ac1fe033e1d43ef69062b16873ad0aa2ad0b1