plasma-umass / doppio

Breaks the browser language barrier (includes a plugin-free JVM).
http://plasma-umass.github.io/doppio-demo
MIT License
2.16k stars 174 forks source link

TypeScript doesn't build #489

Closed PaulBGD closed 7 years ago

PaulBGD commented 7 years ago

Looks like it's due to: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/12942

PaulBGD commented 7 years ago

Oh another issue with the build is that the tasks use an array of AsyncFunctions, which now require 2 generics:

tasks/includes.ts(15,33): error TS2314: Generic type 'AsyncFunction<T, E>' requires 2 type argument(s).
tasks/java.ts(50,22): error TS2314: Generic type 'AsyncFunction<T, E>' requires 2 type argument(s).
tasks/unit_test.ts(9,20): error TS2314: Generic type 'AsyncFunction<T, E>' requires 2 type argument(s).
PaulBGD commented 7 years ago

Looks like a quick fix for both of these issues is to change the typings version for `async: https://github.com/jvilk/BrowserFS/issues/165#issuecomment-263137208

Just removing the caret (^) from async's version seems to fix this.

PaulBGD commented 7 years ago

Found one more issue why it doesn't build: #491

jvilk commented 7 years ago

@PaulBGD is this fixed with your PR? Seems like it is, since the builds are green.

PaulBGD commented 7 years ago

Yep! Thanks for pulling.