search

plasmabio / plasma

Plasma is an e-learning Jupyter-based platform for data analysis
https://docs.plasmabio.org
BSD 3-Clause "New" or "Revised" License
42 stars 12 forks source link

start script support #192

Open jvail opened 2 years ago

jvail commented 2 years ago

It seems adding the start script mentioned here has no effect in plasma. I guess because there is a custom tljh_plasma/entrypoint/entrypoint.sh script. I did change the file and added source ./start here

https://github.com/plasmabio/plasma/blob/7883a6a1266b69ab49f353bdf9974be408bf0709/tljh-plasma/tljh_plasma/entrypoint/entrypoint.sh#L43-L46

Did I miss something or is there a proper way to execute the start script. If not maybe it is possible to add a line to entrypoint.sh?

Thank you Jan

jtpio commented 2 years ago

Thanks @jvail for reporting.

I believe this is right. The tljh-plasma plugin uses a custom entrypoint to be able to start the servers as the users on the host machine. Maybe it should try to execute the start script if it exists, and default to the current exec command otherwise?

jvail commented 2 years ago

Thanks for looking into this issue. I am afraid, I am neither a docker nor a jupyter hub pro. But the little 'hack' into the entrypoint.sh did work for us - but I am not sure if it is the best option to enable the start script. I thought it might be a good idea to make the start script available by default in plasma.

The use case was to run a pip install -e . in order to install a lib in dev mode from within the repo every time the server starts for a specific user. Because otherwise the dev install will live in home/jovyan and wont reflect any changes made after the image is built.