Closed jtpio closed 3 years ago
Hiding the credential inputs in a <section>
tag:
https://user-images.githubusercontent.com/591645/107352301-f4a08d00-6acb-11eb-8a54-545b887d9fd7.mp4
cc @adriendelsalle this makes it possible to provide credentials to be able to clone private repositories.
It looks like providing a username
and password
might be a better option than using basic auth in the repo URL and then stripping it. This also leverages the GIT_CREDENTIAL_ENV
env var from repo2docker
, which is also used in Binder (via the git_credentials
trait)
when this is going to be merged?
@srggrs probably soon.
If you would like to test, you can install the plugin from this branch with the following passed to the TLJH installer:
--plugin git+https://github.com/jtpio/tljh-repo2docker@private-repos
cc @pierrepo in case you have some inputs w.r.t the UI, since it adds two new fields to the dialog (collapsed by default)
Hey @jtpio sorry for the delay. This looks very nice to me. This is a very useful functionality.
Thanks for checking it out :+1:
Fixes #27
This makes it possible to pass a
username
andpassword
from the UI:https://user-images.githubusercontent.com/591645/107351297-bbb3e880-6aca-11eb-9a78-8e4e843260d4.mp4
Using
repo2docker
support forGIT_CREDENTIAL_ENV
(some info in https://github.com/jupyterhub/repo2docker/commit/504aeb7300dce5ee3bd6aaf9a836f96855b435b6)For example with GitHub, a user can generate a new access token with the
read
scope:And use this token as the password.
Similar with GitLab: