Expose custom build-args as advanced option in the UI

plasmabio / tljh-repo2docker

Plugin for The Littlest JupyterHub to build multiple user environments with repo2docker

BSD 3-Clause "New" or "Revised" License

60 stars 15 forks source link

Closed TimoRoth closed 2 years ago

TimoRoth commented 2 years ago

After https://github.com/jupyterhub/repo2docker/pull/1100 got merged, it's now possible to pass custom build-args to the image build process. This exposes that option to the user.

This PR sits on top of my other PR https://github.com/plasmabio/tljh-repo2docker/pull/48 because it has slight overlap. So that one needs to be merged first, and then this one probably needs a quick rebase.

jtpio commented 2 years ago

Thanks @TimoRoth!

jtpio commented 2 years ago

Also if you have a screenshot of the updated UI lying around, it would be great to add it to the top comment of the PR for reference. Thanks!

TimoRoth commented 2 years ago

Rebased and screenshots added

jtpio commented 2 years ago

Great, thanks!