search

plasmabio / tljh-repo2docker

Plugin for The Littlest JupyterHub to build multiple user environments with repo2docker
BSD 3-Clause "New" or "Revised" License
60 stars 15 forks source link

nativeauthenticator's page.html is overshadowed #58

Open yamaton opened 2 years ago

yamaton commented 2 years ago

Hello, I'm running tljh-repo2docker with Native Authenticator. It runs fine, but some links at the top, "Change Password" and "Authorize Users", are gone.

I suppose this is because page.html in nativeauthenticator is overshadowed by the page.html in tljh-repo2docker.

Here is what you'd see if native authenticator is used alone:

yamaton commented 2 years ago

After reading Extending Templates, I figured the {{ super() }} directive is missing in tljh-repo2docker's page.html.

Shall I prepare a PR?

pierrepo commented 2 years ago

Hello @yamaton thanks for your input.

My understanding of tljh-repo2docker is that authentication is handled externally. So, I'm worried that allowing the Native Authenticator could be problematic with other integrations.

Do you have any thought on this @jtpio?

jtpio commented 2 years ago

After reading Extending Templates, I figured the {{ super() }} directive is missing in tljh-repo2docker's page.html.

Ah that could be the case. Thanks @yamaton for catching this, feel free to open a PR to see if that can fix it..