search

plasmicapp / plasmic

Visual builder for React. Build apps, websites, and content. Integrate with your codebase.
https://www.plasmic.app
MIT License
4.78k stars 384 forks source link

Plasmic codegen marks all props as required #16

Closed noga-aviator closed 2 years ago

noga-aviator commented 2 years ago

Jetbrains IDEs have trouble importing and using plasmic codegen, because they think all props are required They'll give error for every not used props, and if you use autocomplete it'll add all props. image (it goes on and on)

yang commented 2 years ago

@noga-aviator That's strange, thanks for reporting.

I can repro the autocompletion providing a bunch of unexpected props, but you may remove/ignore those (no props are required by default—I cannot repro any errors resulting from it).

We'll see if we can appease the Jetbrains inference, and in the meantime please remove/ignore those props.

yang commented 2 years ago

This should be fixed in the next release.

noga-aviator commented 2 years ago

You guys rock ! When's the next release ?

yang commented 2 years ago

Releasing now!

On Wed, Oct 20, 2021 at 12:05 AM noga @.***> wrote:

You guys rock ! When's the next release ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/plasmicapp/plasmic/issues/16#issuecomment-947386954, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABXWJONBB7TBW4K7A7LS3UHZSZ3ANCNFSM5GJZZRXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.