search

plasmicapp / plasmic

Visual builder for React. Build apps, websites, and content. Integrate with your codebase.
https://www.plasmic.app
MIT License
4.72k stars 382 forks source link

Ignore sub-dependencies in findInstalledPackageJsonFile #48

Closed zvictor closed 1 year ago

zvictor commented 1 year ago

Please check #47 for more details on the bug.

https://github.com/plasmicapp/plasmic/issues/47#issuecomment-1207393135 explains how this patch works. My solution is just a quick one to work around the problem for myself, but I do recommend that some extra effort is put into finding a better solution overall.

https://github.com/sindresorhus/resolve-cwd or https://github.com/sindresorhus/resolve-from might be more suitable than running such unnecessary and expensive glob. (I haven't tried fixing this bug with these packages and not sure they will work, but it's just something I recommend trying)

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
contenful-example ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)
plasmic ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)
plasmic-blog-example ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)
plasmic-blog-starter ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)
vercel-workflow ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)
vercel[bot] commented 1 year ago

@zvictor is attempting to deploy a commit to the Plasmic Team on Vercel.

A member of the Team first needs to authorize it.

zvictor commented 1 year ago

@IcaroG anything else I can do for this PR?

IcaroG commented 1 year ago

Sorry for the wait. Merged here https://github.com/plasmicapp/plasmic/commit/8fea13caca046cc9ed725694f7eda2e06bb54ded