plasmo-dev / Plasmo.jl

A Platform for Scalable Modeling and Optimization
Other
143 stars 20 forks source link

Fix slow graph objective #78

Closed jalving closed 1 year ago

jalving commented 1 year ago

This PR replaces lazy node objective updates with the advised JuMP.add_to_expression! function. This removes a major bottleneck in model build-times when there are many optinode objectives.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 :warning:

Comparison is base (ba8520a) 90.37% compared to head (ee2b7c4) 90.29%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================== - Coverage 90.37% 90.29% -0.09% ========================================== Files 19 19 Lines 2307 2307 ========================================== - Hits 2085 2083 -2 - Misses 222 224 +2 ``` | [Impacted Files](https://codecov.io/gh/plasmo-dev/Plasmo.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/optigraph.jl](https://codecov.io/gh/plasmo-dev/Plasmo.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL29wdGlncmFwaC5qbA==) | `85.53% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://codecov.io/gh/plasmo-dev/Plasmo.jl/pull/78/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.