search

plasmo-dev / Plasmo.jl

A Platform for Scalable Modeling and Optimization
Other
143 stars 20 forks source link

Updated `dual(subgraph, linkconstraint)` to call from correct subgraph #90

Closed dlcole3 closed 10 months ago

dlcole3 commented 10 months ago

This is meant to address #86 where dual(subgraph, linkconstraint) does not always use the subgraph graph id to get the dual value of a link constraint. Instead, it always calls the linkconstraint's last solution id.

codecov-commenter commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/optiedge.jl 77.96% <ø> (-0.37%) :arrow_down:
src/optigraph.jl 76.38% <100.00%> (+0.06%) :arrow_up:

:loudspeaker: Thoughts on this report? Let us know!.

jalving commented 10 months ago

Thanks for taking a look at this. Your fix to temporarily switch the last solution id technically works, but it is more correct to just grab the correct solution from the edge mapping (which unfortunately is not documented in any way).