plasmoapp / plasmo-voice

Proximity voice сhat mod for Minecraft
GNU Lesser General Public License v3.0
226 stars 65 forks source link

Placeholders bug #297

Closed NyaomiDEV closed 1 year ago

NyaomiDEV commented 1 year ago

https://github.com/plasmoapp/plasmo-voice/blob/aa1610bdc0712671cf48cea82898ecc7f20bf277/server/paper/src/main/kotlin/su/plo/voice/paper/integration/VoicePlaceholder.kt#L32-L44

How can the camelCase params ever be displayed if you convert them to lowercase before checking?

NyaomiDEV commented 1 year ago

https://github.com/plasmoapp/plasmo-voice/blob/b071af783b1acedeeaf7e86d43b20dada4b9205a/api/server-common/src/main/java/su/plo/voice/api/server/player/VoicePlayer.java#L33-L41

https://github.com/plasmoapp/plasmo-voice/blob/b071af783b1acedeeaf7e86d43b20dada4b9205a/server/paper/src/main/kotlin/su/plo/voice/paper/integration/VoicePlaceholder.kt#L39-L41

Another bug I spotted is that those probably are supposed to be function calls.

Apehum commented 1 year ago

In kotlin, Java methods with prefix is or get can be accessed as kotlin properties

NyaomiDEV commented 1 year ago

In kotlin, Java methods with prefix is or get can be accessed as kotlin properties

Oh, I did not know that. I assumed that because, in my testing, both placeholders return false even when the user has their mic muted or has voice disabled.

Probably the issue is somewhere else, then.

Apehum commented 1 year ago

Should be fixed by 788bd5ec10197bf1cf013d8b2f4971a0fc42fd76

NyaomiDEV commented 1 year ago

Should be fixed by 788bd5e

I offer myself to test it quickly, if you have a jar file to send my way.

Apehum commented 1 year ago

https://github.com/plasmoapp/plasmo-voice/releases/download/2.0.3/PlasmoVoice-Paper-2.0.3.jar

NyaomiDEV commented 1 year ago

https://github.com/plasmoapp/plasmo-voice/releases/download/2.0.3/PlasmoVoice-Paper-2.0.3.jar

It only updates upon join. Subsequent updates don't come through IF DONE VIA HOTKEYS. Toggling in the Plasmo Config section goes through 99% of the times.

Apehum commented 1 year ago

https://github.com/plasmoapp/plasmo-voice/releases/download/2.0.3/PlasmoVoice-Paper-2.0.3.jar

It only updates upon join. Subsequent updates don't come through IF DONE VIA HOTKEYS. Toggling in the Plasmo Config section goes through 99% of the times.

Fixed by eb11b40191b97252871f829bbefb3c8293df9c60