search

plasmoapp / pv-addon-discs

Plasmo Voice Addon. Play custom audio in Minecraft using music discs. Paper only.
MIT License
7 stars 13 forks source link

Hopper / Dropper support #26

Open ikafly144 opened 9 months ago

ikafly144 commented 9 months ago

At this time, playing records using a hopper or dropper and retrieving records using a hopper are not working properly.

ProjectHSI commented 7 months ago

Can confirm this happens. Particles come from the Jukebox but there is no confirmation of sound (Loading action bar text / Title action bar text (e.g. the name of the record)) and no sound is ever played.

I think this is due to JukeboxEventListener's onHopperInsertToJukebox event not being sufficient enough (I.E. not firing or something has gone wrong in it's coding). I don't believe anything on my server is cancelling the event.

One possible solution (to the event not firing in the first place, if that indeed is the problem) is to use org.bukkit.event.inventory.InventoryMoveItemEvent, while sub-optimal as we would need to add more checks, it's possible it could work.

(P.S. I'm not a maintainer of this repository, sorry if the wording makes it sound like it.)

MagmaBro123 commented 6 months ago

Dead project, won't happen.

Danrejk commented 4 months ago

Please! This is the single best thing about plasmo voice!

ProjectHSI commented 3 months ago

@MagmaBro123 I think the devs might not have time to fix the problems here, that or they forgot the issues tab exists. The project is still getting updated. (You can see via the commit messages.)

Apehum commented 3 months ago

Sorry for the really late response. Hoppers and droppers should be supported in the prerelease.

Tested with the latest version of mc 1.20.4, and everything is working fine: https://youtu.be/04FMQC0EBT4

ProjectHSI commented 3 months ago

Sorry for the really late response.

It's OK. Some of my issues never get resolved.