plasmoapp / pv-addon-discs

Plasmo Voice Addon. Play custom audio in Minecraft using music discs. Paper only.
MIT License
7 stars 13 forks source link

The audio won't stop #7

Closed AzimovUA closed 1 year ago

AzimovUA commented 1 year ago

If you pull the disc out of the jukebox, or break the jukebox, then the audio does not stop.

There is no logs in the console.

Info about server: Purpur 1.19.2 pv-addon-discs 1.0.2 (tried 1.0.1) pv-addon-lavaplayer-lib 1.0.4 (tried 1.0.3) PlasmoVoice-Paper 2.0.4

Default config for all plugins, core almost default.

Toldoven commented 1 year ago

Can you test it with pure default Purpur and also Paper?

AzimovUA commented 1 year ago

Can you test it with pure default Purpur and also Paper?

I installed Paper 1.19.2 and deleted all plugins except ProtocolLib (616), PalsmoVoice, pv-addon-discs, and pv-addon-lavaplayer-lib. However, I am still experiencing the same problem. I don't think there's a need to test Purpur since it appears to have the same issue.

Small addition to issue: audio will stop only when it ends (for example music is 3 minutes long, so after 3 minutes it will stop)

Toldoven commented 1 year ago

This happened because in 1.19.4 the API related to Jukebox changed. The plugin is updated to use the latest API. You can either use the previous version of the plugin or use the latest version of Minecraft.

Toldoven commented 1 year ago

Turns out this issue is also present in 1.19.4. No idea when and why it happened, and why there wasn't such an issue before, but I will release a fix soon. Still not sure if it will work on 1.19.2 though

Toldoven commented 1 year ago

Fixed in 1.0.3 https://modrinth.com/plugin/pv-addon-discs/version/1.0.3

foxya27 commented 12 months ago

@KPidS В 1.0.4 проблема появилась, когда два человека одновременно достали пластинку, очень нужен фикс ...

foxya27 commented 12 months ago

Или возможность заблокировать видео/стримы продолжительностью больше часа