Closed v4hn closed 9 years ago
@v4hn this looks good...and rather simple! :neckbeard:
Would you care to add a python test for this so we can make sure it doesn't break in the future? I think all you'd need to do would be to create a cell that utilises ecto::BREAK
here and a sensible test of some sort here. These are actually simpler than they look to add and can be run directly.
I am just checking the docs and it looks like there is no snippet on the return values from ecto cells. If you get this in, I'll add something there covering each of ecto::QUIT
, ecto::OK
, ecto::DO_OVER
and ecto::BREAK
.
Yeah, given how overly complex ecto is, it's refreshing to see easy to understand functionality, isn't it? :D
I just added an appropriate test.
it all looks good to me. Thx !
Thanks @vrabaud Do I get you to release this into indigo? :) (probably together with @stonier's doc changes...
yes, very soon: the doc changes have to be reviewed (@v4hn, please go ahead) and the PR about ARM linkage too.
@vrabaud: done, I reviewed all open requests :sunglasses:
This patch makes ecto schedule the next iteration through the plasm with ecto::BREAK as discussed in https://github.com/plasmodic/ecto/issues/251