Loader didn't return a function error [3.0.0-beta1]

[Aaronius]

When I try to upgrade from 2.x to 3.0.0-beta1 I start getting the following errors:

ERROR in Loader /Users/aahardy/dev/extension-support-testrunner/node_modules/inject-loader/lib/index.js didn't return a function
 @ ./src/lib/actions/__tests__/setCustomerIds.test.js 4:29-64

ERROR in Loader /Users/aahardy/dev/extension-support-testrunner/node_modules/inject-loader/lib/index.js didn't return a function
 @ ./src/lib/sharedModules/__tests__/mcidInstance.test.js 4:32-65

I'm guessing it has to do with the es6 modules in 3.x or something.

[plasticine]

@aaronius thanks will have a look 👍🏼

[oviava]

function inject(source) {
  this.cacheable && this.cacheable();
  return 'module.exports = ' + createInjectorFunction(this, source);
}

// Object.defineProperty(exports, "__esModule", {
//   value: true
// });
// exports.default = inject;

module.exports = inject;

a bit of hit & miss as I don't understand webpack loader system that well but this fixed it for me

[lvthanh101]

hi @plasticine, do you have plan to fix this bug?

[plasticine]

@lvthanh101 Yep, just haven’t had time. Hopefully soon.

[zincli]

hey man, I guess you made a mistake on return value. like @oviava said

function inject(source) {
  this.cacheable && this.cacheable();
  return 'module.exports = ' + createInjectorFunction(this, source);
}

the return value should be a module, it should export some thing. so module.exports here should not omit.

19 got everything broken.

[zincli]

https://github.com/plasticine/inject-loader/blob/master/lib/index.js#L107 here's the problem

[plasticine]

Please check out 3.0.0-beta3 which should fix this issue and also introduces support for webpack2.