search

plasticine / inject-loader

💉📦 A Webpack loader for injecting code into modules via their dependencies.
https://www.npmjs.com/package/inject-loader
MIT License
482 stars 47 forks source link

fix loader export #26

Closed manukall closed 7 years ago

manukall commented 7 years ago

as @zincli noted in #18, this fixes the 'didn't return a function' error.

plasticine commented 7 years ago

Hey @manukall & @getsnoopy, thanks for the PR and the review! :)

Sorry for the delay around fixing this, I’ve been working on a PR for this project for a while (3.0 beta stuff) — which brings support for webpack 2, as well as lots nicer feedback and error messaging to the user, plus a bunch of clean ups. Most importantly it also fixes this rather silly bug... Unfortunately I’ve just been a bit busy to get it over the line until now (see #25).

If it’s OK with you I’d prefer to get that in and shipped instead of this PR.

I’m putting the finishing touches on the above PR and will look to merge it shortly, if you’re active users of this loader I would love feedback if you have any.

plasticine commented 7 years ago

OK, that’s all merged and shipped — would love feedback or reports of issues if you have any. :)