search

plasticine / inject-loader

💉📦 A Webpack loader for injecting code into modules via their dependencies.
https://www.npmjs.com/package/inject-loader
MIT License
484 stars 47 forks source link

karma-phantomjs-launcher should be a dev dependency #28

Closed okize closed 7 years ago

okize commented 7 years ago

karma-phantomjs-launcher is currently listed as a dependency of inject-loader which causes npm warnings for projects that do not use karma. I believe this can be resolved by moving it to the devDependencies list.

└─┬ inject-loader@3.0.0-beta3
  ├── UNMET PEER DEPENDENCY karma@>=0.9
  └─┬ karma-phantomjs-launcher@1.0.2
    └─┬ phantomjs-prebuilt@2.1.14
      ├── es6-promise@4.0.5
      ├─┬ extract-zip@1.5.0
      │ ├─┬ concat-stream@1.5.0
      │ │ └── readable-stream@2.0.6
      │ ├── debug@0.7.4
      │ ├── mkdirp@0.5.0
      │ └─┬ yauzl@2.4.1
      │   └─┬ fd-slicer@1.0.1
      │     └── pend@1.2.0
      ├── fs-extra@1.0.0
      ├── hasha@2.2.0
      ├── kew@0.7.0
      └─┬ request-progress@2.0.1
        └── throttleit@1.0.0

npm WARN karma-phantomjs-launcher@1.0.2 requires a peer of karma@>=0.9 but none was installed.