plasticine / inject-loader

💉📦 A Webpack loader for injecting code into modules via their dependencies.
https://www.npmjs.com/package/inject-loader
MIT License
482 stars 47 forks source link

Add webpack 3 peerDependency, upgrade to webpack 3 #45

Closed nkovacs closed 6 years ago

nkovacs commented 7 years ago

Seems to work fine, make test and make integration-test pass.

There aren't a lot of breaking changes.

plasticine commented 7 years ago

Nice, thanks — will have a look and see if we can't get this shipped. :)

On Tue, 4 Jul 2017 at 9:44 pm, Nikola Kovacs notifications@github.com wrote:

Seems to work fine, make test and make integration-test pass.

There aren't a lot of breaking changes https://github.com/webpack/webpack/releases/tag/v3.0.0.

You can view, comment on, or merge this pull request online at:

https://github.com/plasticine/inject-loader/pull/45 Commit Summary

  • Add webpack 3 peerDependency, upgrade to webpack 3

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/plasticine/inject-loader/pull/45, or mute the thread https://github.com/notifications/unsubscribe-auth/AABGnARkTYD8JfomRumHoec0rwnBWUYCks5sKiWwgaJpZM4ONP5T .

plasticine commented 6 years ago

Thanks! :)

bastimeyer commented 6 years ago

Could you please bump the version and publish a new release with this change? Thanks!

txchen commented 6 years ago

@plasticine would you please release a new version with this? Vuejs users are waiting for webpack 3 templates:) Thanks a lot!