search

plasticine / inject-loader

💉📦 A Webpack loader for injecting code into modules via their dependencies.
https://www.npmjs.com/package/inject-loader
MIT License
482 stars 47 forks source link

fix build & add node 10 #64

Closed seanparmelee closed 4 years ago

seanparmelee commented 5 years ago

I'm using Node 10.16.0 and when I run yarn in this project, I get:

error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9". Got "10.16.0" error Found incompatible module.

I tracked this dependency back to Webpack so I went ahead and bumped webpack and webpack-cli to the latest versions.

But then the next problem I ran into was with the integration tests failing due to a webpack error:

Conflict: Multiple assets emit to the same filename bundle.js

Turns out there was a breaking changing in karma-webpack that happened since the last time inject-loader was released. I went ahead and fixed that here too.

seanparmelee commented 5 years ago

Hi @plasticine, are you still interested in maintaining this project? In addition to this PR, there's some additional work I did that I'd like to contribute back including adding support for ESM and upgrading to Babel 7.

plasticine commented 5 years ago

Hey @seanparmelee, thanks for the message!—and the PR! Sorry for the delay in getting back to you on this, I’ve been a little busy this week, but I’m hoping to catch up on this PR on the weekend!

seanparmelee commented 4 years ago

Hi @plasticine, think you might be able to get to this sometime this week or weekend? Thanks in advance!

seanparmelee commented 4 years ago

Hello again @plasticine, any chance you're available to review this?

seanparmelee commented 4 years ago

Hey @plasticine, wanted to get this on your radar again since it's been a few months.

seanparmelee commented 4 years ago

Hello again @plasticine @vladimir-tikhonov 👋

As I was mentioning before, there's some additional work I'd like to contribute back to this project including adding support for ESM and upgrading to Babel 7. Happy to take ownership or become a collaborator If you're too busy or no longer interested in this project.

treyp commented 4 years ago

thanks for this fix @seanparmelee ! also hoping to get the node 10 support here, and node 12 soon too.

vladimir-tikhonov commented 4 years ago

Hi @seanparmelee, and thanks for you contribution! Changes look good to me. As you probably noticed I'm no longer involved in this project (and never was tbh). While I have permissions to merge you code into master, I don't have any access to inject-loaded package itself, so that will be kinda pointless. I think it will be better to maintain your own fork until @plasticine decide what to do. If you want to publish it to npm I can transfer to you right to conviniently named injectify-loader package that I no longer use.