Add missing comparison to modulo operation

plasticityai / magnitude

A fast, efficient universal vector embedding utility package.

MIT License

1.63k stars 120 forks source link

Add missing comparison to modulo operation #16

Closed vladserkoff closed 6 years ago

vladserkoff commented 6 years ago

Otherwise i % 100000 evaluates to True 99999 out of 100000 times

AjayP13 commented 6 years ago

Good catch! Thanks for submitting this. The main repository is actually on GitLab (https://gitlab.com/Plasticity/magnitude) and the GitHub is just a one-way mirror repository. So I won't merge this PR here, but I'll cherry pick this commit and merge it to the GitLab later. If you have a GitLab account and need this merged in faster, feel free to open a PR there instead.

vladserkoff commented 6 years ago

It's not critical for me, just noticed this bug while reading the code. So feel free to merge whenever you want

AjayP13 commented 6 years ago

Merged, Status Here: https://gitlab.com/Plasticity/magnitude/commit/65fbccf867d132b7031a54423f003a1eb1011675