plasticmacaroni / bg3-missables

Baldur's Gate 3 Missables
7 stars 6 forks source link

Item and Icons contribution #12

Closed asmoranomar closed 8 months ago

asmoranomar commented 8 months ago

Added new icons using the tags "item_common", "item_uncommon", "item_rare", "item_veryrare", "item_legendary", "item_story", "item_ordinary" and "ability". These icons use different colors.

Added a key to explain items under the first heading.

Changed the color of the "missable" icon.

Changed the Nautiloid section to reflect usage of new icons.

All story based equipment has been added (there was not that many). Minor edits to sections that touched on already existing story equipment was done.

Location names for all areas have been changed to reflect the wiki, which should be the actual names in-game. I don't personally believe area names are bad enough to be spoilers, but some might think so. I am working on importing items into the walkthrough and the need for the area names to be accurate for the moment is important. After it is done, the names can be changed to something more obscure.

Not included: I've prepared a separate branch that includes the location for every area in the game. At this time I've removed the empty headers, but future PR's may include them (this is why I'd like location names to stay as they are for now).

If there is no issues with this PR, I can attempt a much larger import of the item list.

plasticmacaroni commented 8 months ago

Okay, I honestly had no idea I could commit without requesting. Let me know what you think of the above @asmoranomar!

Edit: context All I did was update regex matching for symbols to include whitespace, since a lot of the new symbols had a space before the sentence started. I also fixed a single icon.

This is incredible!