search

platanus / activeadmin_addons

Extends ActiveAdmin to enable a set of great optional UX improving add-ons
MIT License
763 stars 288 forks source link

Make sprockets dependency optional #412

Closed joker-777 closed 2 years ago

joker-777 commented 2 years ago

It looks like sprockets will be soon replaced by propshaft. It would be great if we could make the sprockets dependency optional. (https://github.com/platanus/activeadmin_addons/issues/403)

gap777 commented 2 years ago

@ldlsegovia @GabrielLyonB et al... this PR removes a dependency upon sassc-rails, which happens to also make it compatible with Rails 7 + css-bundler (tailwind) + js-bundler (esbuild), which we need in order to use your awesome activeadmin_addons package.

Could you approve this and merge it in?

joker-777 commented 2 years ago

Sorry, I just realized that I created the PR based on my master branch where I pushed lots of other changes I need for my project. Unfortunately, it seems that activeadmin_addons isn't maintained anymore :(

gap777 commented 2 years ago

@joker-777 So sad-- we really liked your changes here!

joker-777 commented 2 years ago

Thanks, maybe I will create another PR but I doubt that there is anyone maintaining this repository.

ldlsegovia commented 2 years ago

@joker-777 We're still alive, thankfully :) Creating a new PR with the sprockets related changes sounds good.

joker-777 commented 2 years ago

@ldlsegovia This is good news!!! I will try to create a new PR then.

Can you also have a look at my other PRs, please? https://github.com/platanus/activeadmin_addons/pull/419 https://github.com/platanus/activeadmin_addons/pull/423

difernandez commented 1 year ago

Hi all, sorry for the late comment. Wanted to let you know that we are planning a beta release for a new major version of this gem, which will drop support for sprockets, among other things. Theses changes will include the removal of sassc and sassc-rails dependencies. We’ll leave the related issues open for now, at least until the release of this version, but will be closing related PRs, as we might need to include similar changes in the removal of sprockets support.