Closed difernandez closed 1 year ago
Can we get a release of this before the whole v2 overhaul?
@jgmontoya even though we won't be backporting things to v1, this seems important enough that we can release it for a last v1 update. I opened #479 for this, so we should be releasing that in the short run
@jgmontoya we just released v1.10.1 , please let us know how it goes if you try it out
Motivation / Background
This Pull Request has been created because ActiveAdmin released v3 🎉 . It has some breaking changes, including requiring of ransack v4, so some changes needed to be done on our part to support it.
Detail
This Pull Request applies a couple of backwards compatible changes that allow this gem to work well with AA v3, and for tests to pass using that version:
ransackable_attributes
andransackable_associations
to dummy app models, as it is now explicitly required by ransack v4contains
), that are now removed from AA. These predicates were backports in AA, and they have been replaced by their already existent Ransack equivalentsAdditional information
Closes #475
Checklist
Before submitting the PR make sure the following are checked: