search

platanus / angular-restmod

Rails inspired REST-API ORM for Angular
http://platanus.github.io/angular-restmod/
MIT License
1.18k stars 87 forks source link

Fixed builder extend function override, instead of _name, name was used #396

Closed utf4 closed 8 years ago

utf4 commented 8 years ago

If I want to extend by overriding any of the builder function already registered, it was not extending because of an underscore was missing in there. Version updation of inflection library was also included for dist/. I have commited dist/* also in case you want to re-build it again with this tiny fix.

utf4 commented 8 years ago

Travis is failing because of missing credentials of saucelabs.com. I cannot put credentials for this repo but I have tested it with my fork and it gone through successfully.

blackjid commented 8 years ago

hey @furqanaziz I've merged https://github.com/platanus/angular-restmod/pull/398 with updated sauce labs credentials... if you want to rebase your PR

blackjid commented 8 years ago

also, I don't think we should be building the dist in the PR, with just build the librar on the releases. That't will help to maintain the PR small and easy to read.

utf4 commented 8 years ago

That is perfect. I am closing this pull request out and will make another clean pull request. Hope you will find chance very soon to review my changes.