Update to elasticsearch 6.x

platanus / elastic-rails

Elasticsearch integration for Ruby on Rails

MIT License

6 stars 5 forks source link

Update to elasticsearch 6.x #4

Closed blackjid closed 5 years ago

blackjid commented 7 years ago

should close #6

blackjid commented 7 years ago

@iobaixas tried a Travis that tests a matrix of ES versions (1.x, 2x y 5.x), but then I thought that maybe a different approach is easier for us to develop and maintain.

I would think that a MAJOR bump to this gem should add support for ES 5.x and drop support for anything else.

The guys from Elasic do this for their elasticsearch-ruby gem, which is a dependency from this repo. https://github.com/elastic/elasticsearch-ruby#compatibility

This means that the next release should be 5.x and we can also tag and release the current version as 2.x

iobaixas commented 6 years ago

cerrado!

blackjid commented 6 years ago

Abierto!

Andres hizo su PR contra este branch, no contra master. Asique esto se queda, hasta que se haga merge de #8

Ahora ojo que yo haria merge de #8 a mano, no desde github, para que no queden merge commits en este PR

iobaixas commented 5 years ago

Un mini resumen de los cambios más importantes:

La nueva versión de elasticsearch ya no soporta multiples 'mapping types' dentro de un indice. La gema permitía tener mas de un 'mapping type' por indice, pero esto no se usaba en ninguna parte. Hubo que hacer un minirefactor para eliminar el uso de types.
Cambiaron los tipos de dato que se usan para guardar texto "buscable" usando fulltext y texto tipo tag. Antes era el dato string, ahora se llaman text o keyword.
Cambió la forma de borrar un indice.
Aproveché de agregar el Makefile para desarrollo.

iobaixas commented 5 years ago

Actualizar gema elastic-rails