search

platanus / potassium

A Rails application generator by Platanus, inspired by Suspenders
MIT License
232 stars 17 forks source link

Update ruby to 2.6.5 (or 2.7.0) #254

Closed rjherrera closed 4 years ago

rjherrera commented 4 years ago

I tested some stuff with ruby 2.7 and it didn't work as expected, maybe because it is a bit green (end of december 2019).

But anyway, we currently have ruby 2.5.5 and we should move to one of those, the latest patch of the 2.6 version or the new 2.7 one.

blackjid commented 4 years ago

Nice, I would love to see this released on the rails 6 release.. at least with 2.6

rjherrera commented 4 years ago

The update to 2.7.0 is almost ready, but one gem we use, sidekiq-scheduler depends on thwait and e2mmap, which are gems that are no longer bundled by default with ruby since 2.7.0 as stated here. As sidekiq-scheduler has not been updated to include those gems as explicit dependencies, our projects will fail.

There is already a PR (https://github.com/moove-it/sidekiq-scheduler/pull/299) to change that in sidekiq-scheduler, and I poked a little bit to speed things up a little. This update depends on that so I will leave this on hold until we have some more news.

Two alternative solutions are 1) use the sidekiq-scheduler PR branch as source for the gem in potassium. 2) update to 2.6.5 until this gets fixed. I don't like either so I think waiting is not that bad.

blackjid commented 4 years ago

Awesome!

Juan Ignacio Donoso

Platanus SpA

On Thu, Jan 30, 2020 at 3:33 PM Raimundo Herrera notifications@github.com wrote:

The update to 2.7.0 is almost ready, but one gem we use, sidekiq-scheduler depends on thwait and e2mmap, which are gems that are no longer bundled by default with ruby since 2.7.0 as stated here https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/. As sidekiq-scheduler has not been updated to include those gems as explicit dependencies, our projects will fail.

There is already a PR (moove-it/sidekiq-scheduler#299 https://github.com/moove-it/sidekiq-scheduler/pull/299) to change that in sidekiq-scheduler, and I poked a little bit to speed things up a little. This update depends on that so I will leave this on hold until we have some more news.

Two alternative solutions are 1. use the sidekiq-scheduler PR branch as source for the gem in potassium. 2) update to 2.6.5 until this gets fixed. I don't like either so I think waiting is not that bad.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/platanus/potassium/issues/254?email_source=notifications&email_token=AABXVRIU7TOEISPRIWZUGZTRAMMQBA5CNFSM4KM3KCY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKMBGRI#issuecomment-580391749, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXVRNOKLE7MCCRLB4N7L3RAMMQBANCNFSM4KM3KCYQ .