search

platanus / potassium

A Rails application generator by Platanus, inspired by Suspenders
MIT License
232 stars 17 forks source link

Unnecessary stdout gem #308

Closed difernandez closed 3 years ago

difernandez commented 4 years ago

In the heroku recipe we are adding the rails_stdout_logging gem. However, this is not necessary since Rails 5, as indicated in their README. The code shown there comes by default in the production.rb generated by rails generator, and apparently heroku automatically enables RAILS_LOG_TO_STDOUT.

The only difference is that by default in a rails generated app STDOUT.sync = false, and the rails_stdout_logging gem had it set to true. This means that Ruby would hold a buffer of logs before writing to standard input, instead of writing immediately. Don't know which we should include though.

rjherrera commented 4 years ago

This may help regarding the STDOUT.sync config. I think it is not that relevant, but I believe keeping the behaviour we had could be a good idea, as it has worked well so far.

difernandez commented 3 years ago

closed in #325