search

plateaukao / einkbro

A small, fast web browser based on Android WebView. It's tailored for E-Ink devices but also works great on normal android devices.
Other
1.13k stars 80 forks source link

Crash when saving epub #252

Closed rhein closed 1 year ago

rhein commented 1 year ago

Every time I try to save a webpage as epub the ap crashes. Tested on multiple sites and 2 devices (android 10 phone, onyx android 11 tablet).

Happy to provide more details, does anybody else observe this problem？

V10.0.5

I have another onyx device with v9.19.0 installed where it works fine.

plateaukao commented 1 year ago

please provide urls that does not work. Also, please try latest version to see if it still happens.

rhein commented 1 year ago

Happens to all urls, e.g. https://github.com/plateaukao/einkbro or also very simple ones with only text such as http://staffweb.hkbu.edu.hk/ppp/cpr/prefs.html

It works up to version 10.4.1 and is broken for 10.5.0 and 10.6.0.

There is actually an epub file saved, but it is corrupted (not a valid zip file). See einkbro.10.6.epub.gz for a broken file, a working one is einkbro.10.4.1.epub.gz - i had to gzip it otherwise could not upload them here.

einkbro.10.6.epub.gz einkbro.10.4.1.epub.gz

plateaukao commented 1 year ago

It looks like caused by too much code optimization. I'll look into it. Thanks for the issue report!

plateaukao commented 1 year ago

@rhein fixed!!! please try v10.6.2

rhein commented 1 year ago

@plateaukao thank you! I can confirm it works with v10.6.2 on both of my devices, so should be good.