plateaukao / einkbro

A small, fast web browser based on Android WebView. It's tailored for E-Ink devices but also works great on normal android devices.
Other
1.13k stars 80 forks source link

[tab bar] Move to next tab (to the right) at tab close. #282

Closed gety9 closed 1 year ago

gety9 commented 1 year ago

First of all thank you for "tab bar" functionality, i've just discovered it and it's super handy!

One issue i have is that when i close current tab it moves to previous tab instead of moving to next, example

-, active tab is "website B" [websiteA] [websiteB X] [websiteC] [websiteD] [websiteE] -, if close it, it moves to the previous tab [websiteA X] [websiteC] [websiteD] [websiteE]

In my opinion it's not UX friendly because -, most people move from left to right when moving from tab to tab -, it's in UX conflict with "new tab (background)". I mean say i am at tab 2, and i "new tab (background)"ed 10 links, now if i move to first of them (tab 3), read it, then close it i am not moving to next link, instead i am again moving to previous tab (on which i already was), of course i could scroll to very end (to tab 12) and read tabs backwords but imho it's not logical (unless you arabic :))


Update: I think i understand why you made tab close move to previous tab, cause on tab view (expanded tab widget) we usully move from bottom to top (cause bottom is nearest to our fingers). But since enabling tab bar i hardly ever use tab view.

Maybe it's good idea to add possibility to set in setting > behavior to move either to previous or to next on tab close? (so user can decide for himself what's most convenient for him)

plateaukao commented 1 year ago
plateaukao commented 1 year ago

https://github.com/plateaukao/einkbro/commit/de8e416af019f20c92c41b5aeb09a10e9e77b1fe

gety9 commented 1 year ago

@plateaukao

thanks for listening to feedback & constantly improving Eink Bro - it's amazing browser! with amazing maintainer :)

closing