search

plateaukao / einkbro

A small, fast web browser based on Android WebView. It's tailored for E-Ink devices but also works great on normal android devices.
Other
1.13k stars 80 forks source link

Make tab bar take into consideration currently active tab #286

Closed gety9 closed 12 months ago

gety9 commented 1 year ago

One more time thank you for tab bar functionality, it's super useful!

Currently there are 2 UX things that we can improve:

1, tab bar is not responding to change of active tab Steps: Say user have 15 tabs open, device width constrains tab bar to displaying only 11 tabs, currently active tab is 11 [tab1][tab2][tab3]...[tab9][tab10][tab11 X]

if user -, presses "+" icon -, OR presses on text link and presses "new tab" -, OR switches to tab 12 using tab widget currently tab bar stays on same position [tab1][tab2][tab3]...[tab9][tab10][tab11]

and user have to scroll manually if he wants to see active tab, close it, etc.

it will be more logical if we auto shift position to [tab2][tab3][tab4]...[tab10][tab11][tab12 X]

2, tab bar position is lost on close / reopen of Eink Bro app Steps Say user have 15 tabs open, device width constrains tab bar to displaying only 11 tabs, currently active tab is 15 [tab5][tab6][tab7]...[tab13][tab14][tab15 X]

If user closes Eink Bro and then reopenes, tab bar reverts to beginning [tab1][tab2][tab3]...[tab9][tab10][tab11]

and user have to scroll manually if he wants to see active tab, close it, etc.

plateaukao commented 1 year ago

I found this issue too. Thanks for pointing it out. I'll see how to fix it with current Jetpack Compose implementation.

gety9 commented 1 year ago

Similar problem is on tab widget. I never noticed it cause on tablet (note air 2) tab widget is big and lots of tabs are displayed at once (so most of the time you will see active tab in view). But now i installed Eink bro on my phone and

-, tab widget position is not saved between open / close (if active tab is at the end you will need to scroll down again to see it)

-, does not respond to active tab change (if active tab is at the end and you open another tab (now it is the active one) it's not in the view - you will need to scroll one tab down manually to see it)

Tab widget issues are less important comparing to tab bar, but i am pointing them out in case if both issues can be fixed with one fix.