plateaukao / einkbro

A small, fast web browser based on Android WebView. It's tailored for E-Ink devices but also works great on normal android devices.
Other
1.13k stars 80 forks source link

Opening a link from intent closes out previously opened tabs (irrespective of the open tabs setting) #302

Closed vdbhb59 closed 9 months ago

vdbhb59 commented 9 months ago

I use Vivo Y35 (Stock Funtouch OS 13), OP5 (A12 Rooted) & LG Wing (A10 Stock), and use EinkBro as main browser.

What device and app version are you using

Describe the bug I have say 2 or 3 tabs open and the browser settings is ON for keeping tabs open even when quit. Now, let us say I have a URL to be opened from some other app or via intent, and when I select EinkBro, the previous opened and pinned tabs vanish/close out automatically. I keep the current opened browser launch running, and open the EinkBro again, and the previously opened tabs have indeed vanished/closed out. Just to let you know, this happens only when opening a link via intent/another app/browser, etc. This has nothing to do with default browser app, battery, BG consumption, running apps, OS related, etc.

To Reproduce Steps to reproduce the behavior.

Description:

  1. EinkBro can be or cannot be a default browser app (it does not matter, as this happens irrespective of default browser app setup)
  2. Keep 2 or 3 tabs opened in EinkBro
  3. Ensure the settings for keeping tabs opened is ON as well
  4. Try to open any link via another app, any other browser, intent call
  5. See the new link open, and the previous tabs getting closed out automatically

Expected behavior Previous opened/running tabs should still be there and the new link should open in a new tab in the EinkBro browser. It looks like EinkBro opens a new broswer launch itself instead of opening in the previous instance (irrespective of running or quit).

Screenshots N.A.

Additional context Seems the browser launches a new instance instead of using the previous instance or the already available instance.

plateaukao commented 9 months ago

I tried latest version (with some new commits after 10.16.1), and it works as expected (other saved tabs are still there). I'll release 10.17.0 and you can try again.

vdbhb59 commented 9 months ago

Working as expected now with the new version from F-Droid @plateaukao Closing this ticket out. Thanks again for the quick resolution. :)