search

plateaukao / einkbro

A small, fast web browser based on Android WebView. It's tailored for E-Ink devices but also works great on normal android devices.
Other
1.05k stars 77 forks source link

Page Reserved Height has no effect #303

Open mhantsch opened 7 months ago

mhantsch commented 7 months ago

What device and app version are you using

Describe the bug I set the Page Reserved Height to different valus, e.g. 50% but a page turn still moves by exactly the same amount. It seems the setting has no effect.

I am trying to get more of an overlap between pages but can't make it work. it does not matter if I turn pages using the device buttons or the on-screen page turn touch zones.

To Reproduce Steps to reproduce the behaviour:

  1. Open web page
  2. Go to settings and set page Reserved Height to 50%
  3. Exit settings and page turn
  4. The Page turns but only 1 or 2 lines of text remain visible from the previous page.

Expected behavior Half of the text of the previous page should still be visible.

plateaukao commented 7 months ago

please only input digits. % is not allowed.

mhantsch commented 7 months ago

I did not put the % sign in the field, only the digits 50.

plateaukao commented 7 months ago

@mhantsch The input number unit is pixel, not percentage of the screen. Usually, the screen height is 768, or 1024. You could try 300, or 500 to see if it's close to what you expected.

mhantsch commented 7 months ago

@plateaukao I did not realise this value was in pixels! Of course the feature works, now I have put in 250, and that makes a big difference. Maybe the text around the entry field should say "in pixels".

mhantsch commented 7 months ago

Or, when the entry has '%' at the end, it could automatically calculate the pixels from the current screen height.

plateaukao commented 7 months ago

Yes, you are right. I'll add description to explain it's in pixels; and modify codes so that users should explicitly add %, and it will take the string as percentage.