search

plateaukao / einkbro

A small, fast web browser based on Android WebView. It's tailored for E-Ink devices but also works great on normal android devices.
Other
1.05k stars 77 forks source link

When downloading, auto populated file name is "default.aspx". #327

Closed gety9 closed 5 months ago

gety9 commented 6 months ago

Env

Bug On some websites when clicking download file default file name is "default.aspx" Instead of one that website suggests, say "mathpuzzles2024". And if you try to download then system can't open it (cause of this name)...

Steps 1, Go to https://www.nasdaqomxnordic.com/aktier/microsite?Instrument=SSE249469 2, Click "Fact Sheet" 3, Try to save file

Additional I saw it on many websites, but assumed it's problem of websites - developers are lazy to suggest human default name. But no, if i go to same website in Kiwi browser default name is human.

Screenshots (first 2 from bottom are kiwi and chrome downloads, last one is eink bro) Screenshot_20240119-165000 Screenshot_2024-01-19_16-51-36

plateaukao commented 6 months ago

The download filename is too complicated to handle. From what EinkBro can get (from the website) in this case, it's default.aspx. You can save it as what_ever_name.pdf, and then you can open it correctly. Unless someone offer a more better way to handle filenames, I have no intentions or methods to fix this.

In this case, I suggest using other browsers to download files. That's what I usually do.

plateaukao commented 6 months ago

By the way, kiwi browser is almost identical to Chrome (it even supports all chrome extensions), they have the same core engine. However, EinkBro uses WebView; it's only a thin layer, so a lot of handlings need to be done by dev.

gety9 commented 6 months ago

@plateaukao

Thanks for explanation on Kiwi, Chrome, etc - i wasn't aware that those examples are useless to our (webview) case (and i am just wasting your time with them).

I understand that download filename process is complicated - it just annoying to switch to other browser when everything is in Eink Bro (all bookmarks, etc).

If download in cases like these (deafult.aspx, google trasnalte web file, etc) works in other webview browser (say FOSS browser) - can we "take inspiration" from it? (so it easier/faster to implement and will be worth pursuing?)

If not, i understand and will close all my download related issues and will ignore all download related bugs in future. (it's just that majority of Eink Bro users are tablet guys, and reading pdfs, etc (= downloading them) seems important feature to have. In this issue at least i can manually type the file name and it will work. In https://github.com/plateaukao/einkbro/issues/326 it's not possible at all to download without going to other browser)

plateaukao commented 6 months ago

If download in cases like these (deafult.aspx, google trasnalte web file, etc) works in other webview browser (say FOSS browser) - can we "take inspiration" from it? (so it easier/faster to implement and will be worth pursuing?)

Yes, it does help if you find it works in FOSS browser, since FOSS browser also uses WebView and it's Open Source. Is it true? if so, I could take a look at FOSS browser implementation, and see if I can port that implementation to EinkBro. If so, maybe I can even remove the file renaming step. (I found it tedious but no way to bypass it now)

plateaukao commented 5 months ago

@gety9 please have a try with version 11.3.0 https://github.com/plateaukao/einkbro/releases/tag/v11.3.0

gety9 commented 5 months ago

@plateaukao works great! thank you! closing!