search

platelet-app / platelet

Dispatch system for emergency volunteer couriers.
https://platelet.app
Apache License 2.0
38 stars 10 forks source link

Guided setup 2 #25

Closed duckbytes closed 2 years ago

duckbytes commented 2 years ago

Merges the guided setup into master.

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
| Secret | Commit | Filename | Detected At | | | ------------------------- | ---------------- | --------------- | -------------------- | -------------------- | | Generic High Entropy Secret | a946ebb1bdf2dd23c51b93c09400a3771e700528 | amplify/backend/awscloudformation/nested-cloudformation-stack.yml | 06:28 January 28th, 2022 | [View secret](https://github.com/platelet-app/platelet/commit/a946ebb1bdf2dd23c51b93c09400a3771e700528#diff-3e837c5c5e977a47d88a44f2589035e75d3ef56fbf03652f67347dba718fe354R197) | | Generic High Entropy Secret | a946ebb1bdf2dd23c51b93c09400a3771e700528 | amplify/backend/awscloudformation/nested-cloudformation-stack.yml | 06:28 January 28th, 2022 | [View secret](https://github.com/platelet-app/platelet/commit/a946ebb1bdf2dd23c51b93c09400a3771e700528#diff-3e837c5c5e977a47d88a44f2589035e75d3ef56fbf03652f67347dba718fe354R198) | | Generic High Entropy Secret | 47d5526f6f379201c8f1f74812a8736e6b639c31 | amplify/backend/awscloudformation/nested-cloudformation-stack.yml | 09:06 February 5th, 2022 | [View secret](https://github.com/platelet-app/platelet/commit/47d5526f6f379201c8f1f74812a8736e6b639c31#diff-3e837c5c5e977a47d88a44f2589035e75d3ef56fbf03652f67347dba718fe354L197) | | Generic High Entropy Secret | 47d5526f6f379201c8f1f74812a8736e6b639c31 | amplify/backend/awscloudformation/nested-cloudformation-stack.yml | 09:06 February 5th, 2022 | [View secret](https://github.com/platelet-app/platelet/commit/47d5526f6f379201c8f1f74812a8736e6b639c31#diff-3e837c5c5e977a47d88a44f2589035e75d3ef56fbf03652f67347dba718fe354L198) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks
codecov-commenter commented 2 years ago

Codecov Report

Merging #25 (6ad99ae) into master (24245ec) will increase coverage by 0.03%. The diff coverage is 30.26%.

:exclamation: Current head 6ad99ae differs from pull request most recent head 47d5526. Consider uploading reports for the commit 47d5526 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   34.81%   34.84%   +0.03%     
==========================================
  Files         208      218      +10     
  Lines        6469     6904     +435     
  Branches     1615     1731     +116     
==========================================
+ Hits         2252     2406     +154     
- Misses       3785     4041     +256     
- Partials      432      457      +25
Impacted Files Coverage Δ
src/components/ClickableTextField.js 93.75% <ø> (ø)
src/components/CustomizedDialogs.js 0.00% <0.00%> (ø)
src/components/UserChip.js 66.66% <ø> (ø)
src/navigation/MainWindow.js 0.00% <0.00%> (ø)
src/scenes/CoordinatorSetup/CoordinatorSetup.js 0.00% <0.00%> (ø)
...cenes/CoordinatorSetup/components/EnhancedTable.js 0.00% <0.00%> (ø)
...es/CoordinatorSetup/components/RiderJobActivity.js 0.00% <0.00%> (ø)
src/scenes/Dashboard/Dashboard.js 0.00% <0.00%> (ø)
...c/scenes/Dashboard/components/GuidedSetupDrawer.js 0.00% <0.00%> (ø)
src/scenes/Dashboard/components/TasksGrid.js 0.00% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24245ec...47d5526. Read the comment docs.