search

platelet-app / platelet

Dispatch system for emergency volunteer couriers.
https://platelet.app
Apache License 2.0
38 stars 10 forks source link

Neaten up the lists of users/vehicles/locations and add filtering #32

Closed duckbytes closed 2 years ago

duckbytes commented 2 years ago

The lists of users/vehicles/locations could be made to look more consistent with each other and a way for the user to filter them and find things more quickly.

Filtering could also search by extra keys like rider responsibility, bike manufacture, or location address line 1.

LamVu1 commented 2 years ago

I'm interested in working on this issue.

LamVu1 commented 2 years ago

Is there more detail on the design?

duckbytes commented 2 years ago

You can see what it looks like at the moment by navigating to /vehicles /users or /locations

It's mostly the spacing and formatting is a bit inconsistent between the different views. Maybe some extra information could be placed on the cards too, like the label of riderResponsibilty (if present).

The loading skeletons also don't match what the list looks like. I think at the moment it imports a component to show the skeleton, but it might be better to just use the Skeleton component from Material UI directly in the list.

duckbytes commented 2 years ago

https://mui.com/components/skeleton/

LamVu1 commented 2 years ago

Okay, I'll start from here then.

LamVu1 commented 2 years ago

@duckbytes I've fixed up the css spacing and made the loading skeletons. How would you want the users to filter? Should it be a dropdown or like the filter search on the dashboard? Are there any specific attributes you think are important for these different lists.

duckbytes commented 2 years ago

Nice, thanks @LamVu1

I think a text search is fine. It could filter for matching name displayName and riderResponsibility.label.

LamVu1 commented 2 years ago

@duckbytes I'm ready to make a pull request but it doesn't seem like I have the permissions.

LamVu1 commented 2 years ago

Should I have forked the repo?

duckbytes commented 2 years ago

Fork is a good way to do it. You could fork it and change the remote URL to the new fork URL. Push your changes up, then open a pull request from your branch on the fork.