search

platenio / site-prototype-v0.1

A project for providing scaffolding of digital tabletop roleplaying tools and other interactive web books.
https://platen.netlify.app
MIT License
4 stars 1 forks source link

Nest component & key hotfix #23

Closed Z33 closed 4 years ago

Z33 commented 4 years ago
michaeltlombardi commented 4 years ago

Questions for you/ @Dastrdlydave:

  1. For nested, is it possible to opt between having the child items be in a scrollable frame vs just unhidden?
  2. Should it be possible to set a custom leading icon for the nest title? ie start with a dice or an exclamation or whatever?

Otherwise this looks awesome!

Z33 commented 4 years ago

Questions for you/ @Dastrdlydave:

  1. For nested, is it possible to opt between having the child items be in a scrollable frame vs just unhidden?
  2. Should it be possible to set a custom leading icon for the nest title? ie start with a dice or an exclamation or whatever?

Otherwise this looks awesome!

  1. Yeah, I think having a max-height attribute would handle this. Two ways to handle this: Default set at 600px with "none" option OR Default is set to "none".
  2. I'm looking into this for all widgets. This will be part of the markdown icon imports.
michaeltlombardi commented 4 years ago

I'd be happy to merge then with a max-height attribute implemented with either default!