fix: publication year is optional - Githubissues

platform-coop-toolkit / coop-library-framework

Custom Post Type utilities for the Platform Co-op Resource Library.

https://platform.coop

Other

0 stars 2 forks source link

fix: publication year is optional #293

Closed greatislander closed 4 years ago

greatislander commented 4 years ago

[x] I've read the guidelines for Contributing to the Platform Co-op Toolkit
[x] This isn't a duplicate of an existing pull request

Description

Publication dates are now optional.

This PR makes the following changes:

Publication year is now an optional field.
Whenever publication year, month, or day fields are modified, the hidden lc_resource_publication_date field is updated to a string in the format YYYY(-MM-DD) OR the string ongoing if year, month, and day are unset.

Steps to test

While editing a resource, inspect the page and find the hidden lc_resource_publication_date field.
Modify the year, month, and day and observe the field's value updating.

Expected behavior: The publication date field updates in sync with changes to year, month, and day.

Additional information

Not applicable.

Related issues

Not applicable.

greatislander commented 4 years ago

@jhung I can't reproduce this. Can you run npm run build and re-test?