platform-coop-toolkit / pinecone

Pattern library for the Platform Cooperative Development Kit.
https://pinecone.platform.coop
BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

Pinecone lacks comprehensive support for Django form markup #369

Closed greatislander closed 4 years ago

greatislander commented 4 years ago

Describe the bug

Django marks up inputs as follows:

<label for="input">Text Input</label>
<input name="input" placeholder="Example input" id="input" type="text" value=""><br>
<span class="helptext">Description for this text input.</span>

The standard Pinecone markup doesn't work. Contrast:

<div class="input-group">
    <label for="input">Text Input</label>
    <input id="input" name="input" placeholder="Example input" type="text" value="">
    <p class="input-group__description">Description for this text input.</p>
</div>

Pinecone needs to support both.

To Reproduce

Explore profile creation flow in https://demo.directory.platform.coop.

Expected behavior

Forms look good.

Additional Context

Not applicable.