search

platform-engineering-org / terraform-gitlab-runners-module

Apache License 2.0
1 stars 2 forks source link

Do not override role_profile_name value assigned by the module #124

Closed lmilbaum closed 5 months ago

lmilbaum commented 5 months ago

Using this module for multiple environment in the same AWS account causing the following errors:

│ Error: creating IAM Instance Profile (dev-gitlab-runners): operation error IAM: CreateInstanceProfile, https response error StatusCode: 409, RequestID: a09e96a7-1f8c-4d94-b84d-4bd7f71205cf, EntityAlreadyExists: Instance Profile dev-gitlab-runners already exists.
│ 
│   with module.runner-instance.aws_iam_instance_profile.instance[0],
│   on .terraform/modules/runner-instance/main.tf line 400, in resource "aws_iam_instance_profile" "instance":
│  400: resource "aws_iam_instance_profile" "instance" {
│ 
╵
╷
│ Error: creating IAM Role (dev-gitlab-runners): operation error IAM: CreateRole, https response error StatusCode: 409, RequestID: 7caf118b-5835-4ee6-813a-160d5d4d3d88, EntityAlreadyExists: Role with name dev-gitlab-runners already exists.
│ 
│   with module.runner-instance.aws_iam_role.instance[0],
│   on .terraform/modules/runner-instance/main.tf line 409, in resource "aws_iam_role" "instance":
│  409: resource "aws_iam_role" "instance" {
│ 
╵

Removing the variable override such that the upstream module would set it value uniquely