search

platform9 / cctl

Apache License 2.0
47 stars 8 forks source link

Fixes for issues 37,38,40 and 41 #43

Closed puneetguptanitj closed 6 years ago

puneetguptanitj commented 6 years ago

Make VIP and routerID mandatory parameters and remove defaults Change name and location of cluster state file Add checks while deleting a machine Fail fast if role is invalid (causes machine to get added in state file without being a master/node)

Fail if vip/routerID not given

./pf9-clusteradm create cluster
Error: required flag(s) "routerID", "vip" not set

Fail to delete last master if cluster still has nodes

./pf9-clusteradm delete machine --ip 10.105.16.15
2018/07/14 19:46:01 Failed to delete machine, cannot delete all masters as cluster has nodes

Fail to create if invalid role

./pf9-clusteradm create machine --ip 10.105.16.32 --role nodedf
2018/07/14 20:04:42 Failed to create machine, invalid role (use node/master)
dlipovetsky commented 6 years ago

Thanks so much for fixing these, @puneetguptanitj! 🙌