Readme should specify pre-requisites that are required in the PF9 UI for OpenStack / include some default fallback options

mmccarre commented 5 years ago

SUMMARY

Express will fail on the pre-flight-checks-openstack role if DVR isn't enabled, DNS servers are not populated, and DNS domain is not filled in. The readme should cover this step and more intelligent error messages would be ideal if Ansible support it.

ISSUE TYPE

Documentation Issue

COMPONENT NAME

OpenStack / pre-flight-checks-openstack role

Express readme

ANSIBLE VERSION

All

STEPS TO REPRODUCE

Leave the Networking Config screen with the defaults as shown

ACTUAL RESULTS

TASK [pre-flight-checks-openstack : debug] *****************************************************************************************************************************************************************
ok: [kvm02] => {
    "msg": "running OpenStack pre_flight_checks():"
}

TASK [pre-flight-checks-openstack : read api token] ********************************************************************************************************************************************************
changed: [kvm02]

TASK [pre-flight-checks-openstack : validate DU global network settings have been configured] **************************************************************************************************************
ok: [kvm02 -> localhost]

TASK [pre-flight-checks-openstack : set_fact] **************************************************************************************************************************************************************
ok: [kvm02]

TASK [pre-flight-checks-openstack : set_fact] **************************************************************************************************************************************************************
fatal: [kvm02]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'dns_domain'\n\nThe error appears to have been in '/opt/pf9-express/roles/pre-flight-checks-openstack/tasks/main.yml': line 28, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- set_fact:\n  ^ here\n"}

PLAY RECAP *************************************************************************************************************************************************************************************************
kvm02                      : ok=23   changed=4    unreachable=0    failed=1

Installation Log: ./log/pf9-express.2019-05-15_04:38:42.log

root@kvm01:/opt/pf9-express#

busterswt commented 5 years ago

You can use the 'default' filter to supply default values in the absence of user-supplied values.

So something like this:

set_fact: neutron_dns_domain: "{{du_result.json.neutron.DEFAULT.dns_domain}}"

can be changed to:

set_fact: neutron_dns_domain: "{{du_result.json.neutron.DEFAULT.dns_domain | default('openstack.local')}}"

And then that could be changed after the fact in the UI if needed?

mmccarre commented 5 years ago

@busterswt Agree! I'll update the title and we can include this.

mmccarre commented 5 years ago

@justgotthis took care of the readme part pull request #209, defaults remaining

platform9 / express