search

platform9 / express

Platform9's on-boarding / automation toolkit
Apache License 2.0
12 stars 10 forks source link

Move failed jinja2 filter to a test #245

Closed pshanbhag closed 4 years ago

pshanbhag commented 4 years ago

Using failed as a jinja2 filter is deprecated as Ansible 2.5 (current latest version is 2.9). It is noticed that using it as a filter is leading to failures on certain setups. Move to using the new way of using failed as a test instead.

See more details here: https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.5.html?highlight=failed#deprecated

Also, some minor cleanup/fixes.

mmccarre commented 4 years ago

@pshanbhag good find, I ran into this on Thursday and was about to look into it as well.