platform9 / express

Platform9's on-boarding / automation toolkit
Apache License 2.0
12 stars 10 forks source link

replace ctrl_ip with du_fqdn for calling management plane APIs #248

Closed jb4free closed 4 years ago

jb4free commented 4 years ago

I haven't had a chance to validate this yet, but I wanted it in somebody's hands in case they have a setup they can check on ASAP.

mmccarre commented 4 years ago

It might be helpful to look at the last pull requests where we considered changing this while fixing multi-region support.

mmccarre commented 4 years ago

To resolve issue #247

pshanbhag commented 4 years ago

I fairly confident w/o additional changes this will break multi-region support. You will want to look at tmp_ip=$(ping -c 1 ${region_url} | grep PING | cut -d ' ' -f3) and ctrl_ip=${tmp_ip:1:((${#tmp_ip}-2))} in the pf9-express bash script

Makes me feel the Ansible goodness should be kept only for the host level stuff and the DU API operations should move into a different place or become Ansible modules (self contained using APIs for qbert and resmgr) themselves.

jb4free commented 4 years ago

I fairly confident w/o additional changes this will break multi-region support. You will want to look at tmp_ip=$(ping -c 1 ${region_url} | grep PING | cut -d ' ' -f3) and ctrl_ip=${tmp_ip:1:((${#tmp_ip}-2))} in the pf9-express bash script

Makes me feel the Ansible goodness should be kept only for the host level stuff and the DU API operations should move into a different place or become Ansible modules (self contained using APIs for qbert and resmgr) themselves.

all of this should move to express-cli