search

platform9 / luigi

The plumber you'll hire to install all your Kubernetes network plumbing
Apache License 2.0
21 stars 3 forks source link

PMK-6377 Changing the label for hostplumber #179

Closed vedantjoshi84 closed 3 months ago

vedantjoshi84 commented 3 months ago

Issue: PMK-6377

Summary: Both Luigi and hostplumber pods have the same label as controller-manger. When we delete network plugin, it uses controller-manger label to pass request to webhook. Since both luigi and hostplumber pods have same labels, request was getting forwarded to, sometimes, hostplumber pod and sometimes, to the luigi pod, which was causing timeouts. Changing the label and selector for hostplumber.

Testing: https://platform9.atlassian.net/browse/PMK-6377?focusedCommentId=98311

cruizen commented 3 months ago

@vedantjoshi84 Please backport to the branch v0.5.4 too. https://github.com/platform9/airctl/blob/platform9-v5.10/conf/pmk_cluster_img_list.json When publishing a new Luigi image from Teamcity, the build configuration takes a parameter so that the image tag will be v0.5.4 and not v0.5.4-pmk-xxx - refer the build parameters for tagged builds earlier.

vedantjoshi84 commented 3 months ago

Backport: https://github.com/platform9/luigi/pull/180

poojaghumre commented 3 months ago

v0.5.4 luigi image was already released to customers, so we should push this change to v0.5.5 branch once build passes on master branch