search

platform9 / luigi

The plumber you'll hire to install all your Kubernetes network plumbing
Apache License 2.0
21 stars 3 forks source link

Make image push target different, for luigi and hostplumber #190

Closed vedantjoshi84 closed 1 month ago

vedantjoshi84 commented 3 months ago

Summary: There are different Teamcity build configurations for luigi and hostplumber the line to build hostplumber was commented in Luigi’s build step, as the image build variable name was same for luigi and hostplumber.

Testing: This build pushed luigi, hostplumber and dhcp images: https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9ComponentsForKubernetes_LuigiPlugins/3268117

cruizen commented 1 month ago

@vedantjoshi84 we can close this PR. This has been addressed in v0.5.6 as part of https://github.com/platform9/luigi/pull/213 (needs to be ported to master)

vedantjoshi84 commented 1 month ago

@vedantjoshi84 we can close this PR. This has been addressed in v0.5.6 as part of #213 (needs to be ported to master)

Closing it.