search

platform9 / ssh-provider

SSH Machine Controller for the Cluster API
11 stars 4 forks source link

Increase verbosity by adding log statements #31

Closed sarun87 closed 6 years ago

sarun87 commented 6 years ago

machine create, i.e. deploying etcd and kubernetes control plane takes a while and this needs to be called out to the user. This change set explicitly calls this out and adds further important log statements.

Note: If a go binary uses log.Printx statement and this binary is called using client.RunCommand today, the log.Printx statements don't appear in stdOut. They appear as part of stdErr. Only fmt.Printxx is seen in stdOut. We may need to output both stdOut and stdErr for a successful command run, but it would be good if this can be controlled by a verbosity parameter passed to the actuator during initialization (or) as a configuration setting.

dlipovetsky commented 6 years ago

Thanks for adding these back.

Sounds like we should be logging to stdout, not stderr. I'll file issues