search

platform9 / ssh-provider

SSH Machine Controller for the Cluster API
11 stars 4 forks source link

Node delete fails if nodeadm not present in /opt/bin #42

Open puneetguptanitj opened 6 years ago

puneetguptanitj commented 6 years ago

Deletion of node fails if the nodeadm binary is not present in /opt/bin. It should fetch the correct binary from the cache

sarun87 commented 6 years ago

I have a concern here. A machine should be part of the k8s cluster to begin with for deletion operation and that would mean the right binaries had been placed in /opt/bin. Should we be fetching binaries for deletion at all? I mean, do we want to fix this?

puneetguptanitj commented 6 years ago

Hi Arun, yeah ideally those binaries should still be there with the right versions from the last create operation. This is to just to make sure that it is the case. The operation would be a no op if the required binary is already there