platform9 / ssh-provider

SSH Machine Controller for the Cluster API
11 stars 4 forks source link

Modify advertise address to be host IP #52

Closed ojmhetar closed 6 years ago

ojmhetar commented 6 years ago

Addresses #48 and https://github.com/platform9/nodeadm/issues/54

ojmhetar commented 6 years ago

Sure, @vannrt , I'll include some of this in the commit message, but here is some context - kubelet uses a liveness probe to check the availability of the kube-apiserver. If the probe fails the check, it will restart the local apiserver container. The problem occurs when the VIP is used as the address for the liveness probe; in this case, the apiserver might not be running on the same machine as the kubelet which sent the check. The probe is incorrectly querying the remote apisever. If the remote apiserver is unhealthy, it could cause the (local) healthy container to fall in a restart loop.

https://github.com/platform9/nodeadm/issues/54