platformatic / meraki

Wizard for stackables app
Apache License 2.0
30 stars 1 forks source link

Changing the entrypoint in "edit" does not work #808

Open mcollina opened 1 month ago

tonysnowboardunderthebridge commented 1 month ago
Schermata 2024-07-18 alle 11 42 30

UI passed the following object on update, updating the name of entrypoint

{
    "projectName": "test-808",
    "services": [
        {
            "name": "pippo",
            "template": "@platformatic/composer",
            "fields": [],
            "plugins": []
        },
        {
            "name": "paperino",
            "template": "@platformatic/service",
            "fields": [],
            "plugins": []
        },
        {
            "name": "pluto",
            "template": "@platformatic/service",
            "fields": [],
            "plugins": []
        }
    ],
    "entrypoint": "pluto",
    "port": "3042",
    "logLevel": "info",
    "typescript": true,
    "createGitHubRepository": false,
    "installGitHubActions": false
}

but there is no change on the UI, also after closing meraki and opening again the application

Schermata 2024-07-18 alle 11 51 47
marcopiraccini commented 1 month ago

I think that the problem is that we don't pass the entrypoint to the generator, see: https://github.com/platformatic/meraki/blob/main/src/main/generate.mjs#L163

@leorossi there is a reason why we are not passing it in the "update" case? Just passing it will solve the issue?

leorossi commented 1 month ago

Seems like that only this is needed: https://github.com/platformatic/platformatic/pull/2849

When this lands, I will update meraki with the latest platformatic release

mcollina commented 1 month ago

@leorossi is there work left to do for this?

leorossi commented 1 month ago

Just a new release of Platformatic

mcollina commented 1 month ago

That was done

marcopiraccini commented 1 month ago

This needs a change on Meraki too